Suspicious warnings when building for x86-64

[belegdol]

I have submitted museek+ into Fedora Extras, users will be able to install it with yum install museek+ soonish. During the review process, the reviewer reported that building for x86-64 generates the following warnings:

./Muhelp/string_ext.hh:61: warning: comparison is always true due to limited range of data type ./Muhelp/string_ext.hh:64: warning: comparison is always false due to limited range of data type ./Muhelp/string_ext.hh:79: warning: comparison is always true due to limited range of data type ./Muhelp/string_ext.hh:82: warning: comparison is always false due to limited range of data type ./Muhelp/string_ext.hh:97: warning: comparison is always true due to limited range of data type ./Muhelp/string_ext.hh:100: warning: comparison is always false due to limited range of data type ./Muhelp/string_ext.hh:114: warning: comparison is always true due to limited range of data type ./Muhelp/string_ext.hh:117: warning: comparison is always false due to limited range of data type

He said that they look suspicious. Could you please have a look?

[cooldwind@…]

std::string::npos is size_t, which is bigger than int in x86_64. Using size_t where appropiate.

[cooldwind@…]

Correct more variables which I missed in the previous patch.

[lbponey]

Thanks! Patch applied in #889.

[Makalah]

Touchdown! That's a raelly cool way of putting it!