Ticket #48 (closed defect: fixed)

Opened 21 months ago

Last modified 3 months ago

Friend-shares: only one file can be queued at a time for soulseek clients

Reported by: controlpanel1@… Owned by: daelstorm
Priority: critical Milestone: Release 0.2.0
Component: museekd Version: 0.1.12
Keywords: Cc:

Description

When museek is set up with different share lists (buddies, and everyone), people downloading off of the buddy-shares-list can only queue up one file at a time with the soulseek client. The rest of the files get the status: "Remote: File Not Found", and they have to be retried, one at a time. This problem only affects soulseek clients, and works fine if the downloading client is museek. Strangely enough, this problem does NOT occur if the settings are changed such that ALL shares are only available to friends, and then "buddy" attempts to download off of the general-sharing list using the Soulseek client.

Attachments

Change History

follow-up: ↓ 2   Changed 19 months ago by gandalf

  • priority changed from major to critical
  • type changed from task to defect
  • milestone set to Release 0.2.0

Confirmed.

Really annoying....

in reply to: ↑ 1   Changed 16 months ago by anonymous

Indeed, extremely annoying.

Replying to gandalf:

Confirmed. Really annoying....

  Changed 3 months ago by anonymous

A simple patch to solve that: in /trunk/sources/Museek/PeerConnection.cc at line 321 replace this line:

} else if(! mMuseek->shares()->is_shared(s.filename)) {

by this one:

} else if(! mMuseek->shares()->is_shared(s.filename) && ! mMuseek->buddyshares()->is_shared(s.filename)) {

Tested succesfully. Hope it'll make into svn soon.

  Changed 3 months ago by daelstorm

  • status changed from new to closed
  • resolution set to fixed

Committed in #744

Add/Change #48 (Friend-shares: only one file can be queued at a time for soulseek clients)

Author



Action
as closed
Next status will be 'reopened'
 
Note: See TracTickets for help on using tickets.